Horton

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Liudmila Mantrova <l.mantrova@postgrespro.ru>

View thread
From: Liudmila Mantrova <l.mantrova@postgrespro.ru>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>, Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andrey Borodin <x4mmm@yandex-team.ru>, David Steele <david@pgmasters.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2019-07-26T17:43:40Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

Attachments

On 7/1/19 5:20 PM, Alexey Kondratov wrote:
> Hi Thomas,
>
> On 01.07.2019 15:02, Thomas Munro wrote:
>
>> Hi Alexey,
>>
>> This no longer applies.  Since the Commitfest is starting now, could
>> you please rebase it?
>
> Thank you for a reminder. Rebased version of the patch is attached. 
> I've also modified my logging code in order to obey new unified 
> logging system for command-line programs commited by Peter (cc8d415117).
>
>
> Regards
>
Hi Alexey,

I would like to suggest a couple of changes to docs and comments, please 
see the attachment.
The "...or fetched on startup" part also seems wrong here, but it's not 
a part of your patch, so I'm going to ask about it on psql-docs separately.

It might also be useful to reword the following error messages:
- "using restored from archive version of file \"%s\""
- "could not open restored from archive file \"%s\"
We could probably say something like "could not open file \"%s\" 
restored from WAL archive" instead.

On a more general note, I wonder if everyone is happy with the 
--using-postgresql-conf option name, or we should continue searching for 
a narrower term. Unfortunately, I don't have any better suggestions 
right now, but I believe it should be clear that its purpose is to fetch 
missing WAL files for target. What do you think?

-- 
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company