Re: On non-Windows, hard depend on uselocale(3)

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>, Tristan Partin <tristan@neon.tech>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-02-09T07:32:34Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert "Tidy up locale thread safety in ECPG library."
- 3c8e463b0d88 18.0 landed
Tidy up locale thread safety in ECPG library.
- 8e993bff5326 18.0 landed
Revert "Blind attempt to fix _configthreadlocale() failures on MinGW."
- a62d90f2e5cb 18.0 landed
Require ucrt if using MinGW.
- 1758d4244616 18.0 landed
Remove configure check for _configthreadlocale().
- f1da075d9a03 18.0 landed
Simplify checking for xlocale.h
- 9c2a6c5a5f4b 18.0 landed
All supported systems have locale_t.
- 8d9a9f034e92 17.0 cited

Attachments

v7-0001-Tidy-up-locale-thread-safety-in-ECPG-library.patch (text/plain) patch v7-0001
v7-0002-Fixup-fix-compiler-warnings-if-LC_C_LOCALE-exists.patch (text/plain) patch v7-0002
v7-0003-Fixup-sort-some-lists-better.patch (text/plain) patch v7-0003

Checking the status of this thread ...

The patches that removed the configure checks for _configthreadlocale(), 
and related cleanup, have been committed.

The original patch to "Tidy up locale thread safety in ECPG library" is 
still outstanding.

Attached is a rebased version, based on the posted v6, with a couple of 
small fixups from me.

I haven't re-reviewed it yet, but from scanning the discussion, it looks 
close to done.