Re: Views no longer in rangeTabls?
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-06-10T07:30:29Z
Lists: pgsql-hackers
On 6/10/23 09:57, Amit Langote wrote: > On Sat, Jun 10, 2023 at 15:51 David Steele <david@pgmasters.net > <mailto:david@pgmasters.net>> wrote: > On 6/9/23 19:14, Tom Lane wrote: > > > > If you see "rte->rtekind == RTE_SUBQUERY && OidIsValid(rte->relid)", > > it's dead certain that relid refers to a view, so you could just wire > > in that knowledge. > > Yeah, that's a good trick. Even so, I wonder why relkind is not set > when > relid is set? > > I too have been thinking that setting relkind might be a good idea, even > if only as a crosscheck that only view relations can look like that in > the range table. +1. Even better if we can do it for PG16. Regards, -David
Commits
-
Retain relkind too in RTE_SUBQUERY entries for views.
- 0f8cfaf8921f 16.0 landed