Re: Online enabling of checksums

Joshua D. Drake <jd@commandprompt.com>

From: "Joshua D. Drake" <jd@commandprompt.com>
To: Bruce Momjian <bruce@momjian.us>, Daniel Gustafsson <daniel@yesql.se>
Cc: Sergei Kornilov <sk@zsrv.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Magnus Hagander <magnus@hagander.net>
Date: 2018-07-31T19:52:40Z
Lists: pgsql-hackers
On 07/31/2018 12:45 PM, Bruce Momjian wrote:
>
>> Hi!,
>>
>> Thanks for reviewing, I’ve updated the patch with the above mentioned incorrect
>> linkends as well as fixed the comments you made in a previous review.
>>
>> The CF-builder-bot is red, but it’s because it’s trying to apply the already
>> committed patch which is in the attached datallowconn thread.
> I think checksumhelper_cost_delay should be checksum_helper_cost_delay.
>                                                      ^
>
> Is "helper" the right word?

Based on other terminology within the postgresql.conf should it be 
"checksum_worker_cost_delay"?

JD

>

-- 
Command Prompt, Inc. || http://the.postgres.company/ || @cmdpromptinc
***  A fault and talent of mine is to tell it exactly how it is.  ***
PostgreSQL centered full stack support, consulting and development.
Advocate: @amplifypostgres || Learn: https://postgresconf.org
*****     Unless otherwise stated, opinions are my own.   *****



Commits

  1. Online enabling and disabling of data checksums

  2. Deactive flapping checksum isolation tests.

  3. Add support for coordinating record typmods among parallel workers.