Horton

Thread

Commits

  1. Clarify pg_dump documentation

  1. pg_dump --exclude-* options documentation

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2019-09-02T06:32:22Z

    We have the following options in pg_dump:

--exclude-schema=schema
--exclude-table=table
--exclude-table-data=table

and new in pg_dumpall:

--exclude-database=pattern

I was momentarily confused that the latter is documented as taking a
"pattern" but the others are not.  Of course they all take the same kind
of pattern.

Should we change the documentation of the old pg_dump options to also
take a "pattern", or change the documentation of the new pg_dumpall
option to read "database"?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  2. Re: pg_dump --exclude-* options documentation

    Fabien COELHO <coelho@cri.ensmp.fr> — 2019-09-02T06:34:56Z

    > We have the following options in pg_dump:
>
> --exclude-schema=schema
> --exclude-table=table
> --exclude-table-data=table
>
> and new in pg_dumpall:
>
> --exclude-database=pattern
>
> I was momentarily confused that the latter is documented as taking a
> "pattern" but the others are not.  Of course they all take the same kind
> of pattern.
>
> Should we change the documentation of the old pg_dump options to also
> take a "pattern", or change the documentation of the new pg_dumpall
> option to read "database"?

My 0.02€: we should use the more general and precise, i.e. pattern.

-- 
Fabien.

  3. Re: pg_dump --exclude-* options documentation

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-09-02T14:55:01Z

    Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Should we change the documentation of the old pg_dump options to also
>> take a "pattern", or change the documentation of the new pg_dumpall
>> option to read "database"?

> My 0.02€: we should use the more general and precise, i.e. pattern.

+1 ... it doesn't seem to me that "--exclude-schema=schema" conveys
anything useful.

			regards, tom lane

  4. Re: pg_dump --exclude-* options documentation

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2019-09-03T12:28:17Z

    On 2019-09-02 16:55, Tom Lane wrote:
> Fabien COELHO <coelho@cri.ensmp.fr> writes:
>>> Should we change the documentation of the old pg_dump options to also
>>> take a "pattern", or change the documentation of the new pg_dumpall
>>> option to read "database"?
> 
>> My 0.02€: we should use the more general and precise, i.e. pattern.
> 
> +1 ... it doesn't seem to me that "--exclude-schema=schema" conveys
> anything useful.

done

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services