Horton

Re: Tree-walker callbacks vs -Wdeprecated-non-prototype

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-05-22T14:47:06Z
Lists: pgsql-hackers 
Hi,

On 2022-12-13 14:18:48 +1300, Thomas Munro wrote:
> On Mon, Dec 12, 2022 at 4:43 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > On Mon, Dec 12, 2022 at 4:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > I'm for "turn the warning off".  Per previous discussion, adhering
> > > strictly to that rule would make our code worse (less legible AND
> > > less safe), not better.
> >
> > Alright, this seems to do the trick here.
> 
> That did fix that problem.  But... seawasp also just recompiled its
> compiler and picked up new opaque pointer API changes.  So no green
> today.  I have more work to do to fix that, which might take some time
> to get back to.

Presumably due to conflict resolution, this commit added an empty meson.build
to REL_13_STABLE. I'll remove that...

Greetings,

Andres Freund

Commits

  1. Remove accidentally added meson.build

  2. Disable clang 16's -Wcast-function-type-strict.

  3. Disable -Wdeprecated-non-prototype in the back branches.

  4. Revise tree-walk APIs to improve spec compliance & silence warnings.

  5. Future-proof the recursion inside ExecShutdownNode().