Horton

Re: Inconsistency in reporting checkpointer stats

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-02T02:21:50Z
Lists: pgsql-hackers 

On 2024/10/02 1:50, Nitin Jadhav wrote:
>> Before committing the patch, I revised it with the following changes:
>>
>> - I added "shared" to the description of pg_stat_checkpointer.buffers_written
>>    to clarify that it tracks shared buffers.
>> - In the checkpoint log message, I replaced "slru" with "SLRU" for consistency,
>>    as uppercase is typically used for SLRU.
>> - I updated the commit message.
> 
> Thanks for updating. Looks good to me.

Thanks for the review! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Fix inconsistent reporting of checkpointer stats.

  2. Defer flushing of SLRU files.