Re: Improve new hash partition bound check error messages

On 2021-02-03 15:52, Peter Eisentraut wrote:
> On 2021-02-02 13:26, Heikki Linnakangas wrote:
>> How about this?
>>
>> CREATE TABLE fail_part PARTITION OF hash_parted FOR VALUES WITH (MODULUS
>> 25, REMAINDER 3);
>> ERROR:  every hash partition modulus must be a factor of the next larger
>> modulus
>> DETAIL:  25 is not divisible by 10, the modulus of existing partition
>> "hpart_1"
> 
> I don't know if we can easily get the name of the existing partition.
> I'll have to check that.
> 
> I'm worried that this phrasing requires the user to understand that
> "divisible by" is related to "factor of", which is of course correct but
> introduces yet more complexity into this.
> 
> I'll play around with this a bit more.

Here is a new patch that implements the suggestions.