Horton
Menu

Re: Unexpected behavior when setting "idle_replication_slot_timeout"

Laurenz Albe <laurenz.albe@cybertec.at>

View thread
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, 'Amit Kapila' <amit.kapila16@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Gunnar Morling <gunnar.morling@googlemail.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Date: 2025-07-10T05:51:36Z
Lists: pgsql-bugs 
On Thu, 2025-07-10 at 05:27 +0000, Hayato Kuroda (Fujitsu) wrote:
> > > The "hybrid approach" saves the two seconds on system with injection points,
> > > but cannot simplify the code.
> > 
> > I feel that would be a needless complexity in the test.
> 
> Yeah, it is the down side of the approach. If it do not have enough advantage, let's drop the idea.

Great, then I think that we have consensus.
Let's change to seconds and leave the injectsion points and tests as they are.

I'd still like to see the documentation improved, like my patch tried to do.

Yours,
Laurenz Albe

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Clarify meaning of "idle" in idle_replication_slot_timeout.

  2. Change unit of idle_replication_slot_timeout to seconds.