Re: [PATCH] add concurrent_abort callback for output plugin
Markus Wanner <markus.wanner@enterprisedb.com>
From: Markus Wanner <markus.wanner@enterprisedb.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ajin Cherian <itsajin@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-31T13:50:53Z
Lists: pgsql-hackers
On 31.03.21 15:18, Amit Kapila wrote: > On Wed, Mar 31, 2021 at 11:55 AM Markus Wanner >> The last sentences there now seems to relate to just the setting of >> "concurrent_abort", rather than the whole reason to invoke the >> prepare_cb. And the reference to the "gid" is a bit lost. Maybe: >> >> "Thus even in case of a concurrent abort, enough information is >> provided to the output plugin for it to properly deal with the >> <command>ROLLBACK PREPARED</command> once that is decoded." > > Okay, Changed the patch accordingly. That's fine with me. I didn't necessarily mean to eliminate the hint to the concurrent_abort field, but it's more concise that way. Thank you. Regards Markus
Commits
-
Avoid sending prepare multiple times while decoding.
- f25a4584c6f5 14.0 landed
-
Ensure to send a prepare after we detect concurrent abort during decoding.
- 4778826532a6 14.0 landed