Horton

Re: WARNING: relcache reference leak: relation "p1" not closed

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael.paquier@gmail.com>, Kevin Grittner <kgrittn@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-03-08T01:55:57Z
Lists: pgsql-hackers 
On 2017/03/08 1:34, Robert Haas wrote:
> On Tue, Mar 7, 2017 at 1:43 AM, Amit Langote wrote:
>> On 2017/03/07 14:04, Tom Lane wrote:
>>> Therefore, there should definitely be a partitioned table, hopefully with
>>> a less generic name than "p1", in the final regression DB state.  Whether
>>> this particular one from alter_table.sql is a good candidate, I dunno.
>>> But let's not drop it without adding a better-thought-out replacement.
>>
>> OK, let's drop p1 in alter_table.sql.  I think a partitioned table created
>> in insert.sql is a good candidate to keep around after having it renamed,
>> which patch 0003 does.
> 
> Committed 0001.
> 
> Committed 0002 and 0003 together.

Thanks.

Regards,
Amit

Commits

  1. Give partitioned table "p" in regression tests a less generic name.

  2. Fix relcache reference leak.

  3. Combine several DROP variants into generic DropStmt

  4. Reorder the asynchronous libpq calls for replication connection

  5. Don't uselessly rewrite, truncate, VACUUM, or ANALYZE partitioned tables.