Horton

Re: [PATCH] Provide more information to filter_prepare

Markus Wanner <markus.wanner@enterprisedb.com>

View thread View on postgr.es
From: Markus Wanner <markus.wanner@enterprisedb.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Ajin Cherian <itsajin@gmail.com>
Date: 2021-03-29T10:52:01Z
Lists: pgsql-hackers 
On 29.03.21 12:18, vignesh C wrote:
> But in prepare_filter_cb callback, by stating "other systems ..." it is 
> not very clear who will change the GID. Are we referring to 
> publisher/subscriber decoding?

Thanks for your feedback.  This is not about GIDs at all, but just about 
identifying a transaction.  I'm out of ideas on how else to phrase that. 
  Any suggestion?

Maybe we should not try to give examples and reference other systems, 
but just leave it at:

      The <parameter>ctx</parameter> parameter has the same contents as for
      the other callbacks. The parameters <parameter>xid</parameter>
      and <parameter>gid</parameter> provide two different ways to identify
      the transaction.  The later <command>COMMIT PREPARED</command> or
      <command>ROLLBACK PREPARED</command> carries both identifiers,
      providing an output plugin the choice of what to use.

That is sufficient an explanation in my opinion.   What do you think?

Regards

Markus

Commits

  1. Add a xid argument to the filter_prepare callback for output plugins.