Horton

Re: Latest patches break one of our unit-test, related to RLS

Laurenz Albe <laurenz.albe@cybertec.at>

View thread View on postgr.es
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dominique Devienne <ddevienne@gmail.com>, pgsql-general@postgresql.org
Date: 2025-09-13T22:38:10Z
Lists: pgsql-general 
On Sat, 2025-09-13 at 17:00 -0400, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > I came up with the attached patch set.
> 
> I did some more work on the comments, adjusted a couple of places that
> could be simplified, and pushed it.

Thank you!

> > I used two separate patches for clarity and ease of review, but both
> > should get backpatched.
> 
> I didn't really love the "fix it and then explain it afterward"
> approach.  It's hard to review a patch if you don't understand the
> logic.  I considered swapping the order of the two patches, but
> eventually just merged them into one.

Yes, having the refactoring patch first might have been better.

Yours,
Laurenz Albe

Commits

  1. Amend recent fix for SIMILAR TO regex conversion.

  2. Fix conversion of SIMILAR TO regexes for character classes