Horton

Re: backend/nodes cleanup: Move loop variables definitions into for statement

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-24T15:00:04Z
Lists: pgsql-hackers 
On 19.11.25 11:32, Chao Li wrote:
> On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter@eisentraut.org 
> <mailto:peter@eisentraut.org>> wrote:
> 
> 
> 
>     In a couple of cases, you are changing the type of the loop variable
>     from Size to int.  I would not expect such a change in a patch of this
>     nature.  If you have a reason to change it, please explain it (but I
>     doubt the change is correct).
> 
> 
> That was a mistake. I fixed it in v3.

Still not correct in outDatum().

Commits

  1. backend/nodes cleanup: Move loop variables definitions into for statement

  2. formatting.c cleanup: Move loop variables definitions into for statement