Re: backend *.c #include cleanup (IWYU)
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-02-12T16:08:40Z
Lists: pgsql-hackers
On 10.02.24 21:13, Nathan Bossart wrote: >> (Interestingly, IWYU has been mentioned in src/tools/pginclude/README since >> 2012. Has anyone else played with it? Was it not mature enough back then?) > I haven't played with it at all, but the topic reminds me of this thread: > > https://postgr.es/m/flat/CALDaNm1B9naPDTm3ox1m_yZvOm3KA5S4kZQSWWAeLHAQ%3D3gV1Q%40mail.gmail.com Approaches like that as well as the in-tree pgrminclude work by "I removed the #include and it still compiled fine", which can be unreliable. IWYU on the other hand has the compiler tracking where a symbol actually came from, and so if it says that an #include is not used, then it's pretty much correct by definition.
Commits
-
Remove unused #include's from backend .c files
- dbbca2cf299b 17.0 landed