Horton

Re: pg_upgrade: Improve invalid option handling

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>, Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-06-19T19:51:43Z
Lists: pgsql-hackers 
On 2019-06-19 04:24, Michael Paquier wrote:
> On Tue, Jun 18, 2019 at 10:25:44AM +0200, Daniel Gustafsson wrote:
>> Correct, that matches how pg_basebackup and psql does it.
> 
> Perhaps you have a patch at hand?  I can see four strings in
> pg_upgrade, two in exec.c and two in option.c, which could be
> improved.

Committed my patch and the fixes for those error messages.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. pg_upgrade: Improve error messages

  2. pg_upgrade: Improve invalid option handling