Horton

Re: [PATCH] Improve geometric types

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: emre@hasegeli.com
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@enterprisedb.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-07-30T10:42:51Z
Lists: pgsql-hackers 

On 07/30/2018 11:57 AM, Emre Hasegeli wrote:
>> OK, thanks for confirming. I'll get it committed and we'll see what the
>> animals think soon.
> 
> Thank you for fixing this.  I wanted to preserve this code but wasn't
> sure about the correct place or whether it is still necessary.
> 
> There are more places we produce -0.  The regression tests have
> alternative results to cover them.  I have the "float-zero" patch for
> this.  Although I am not sure if it is a correct fix.  I think we
> should find the correct fix, and apply it globally to floating point
> operations.  This can be only enabled for platforms which produce -0,
> so the others don't have to pay the price.
> 

Hmmm. It'll be difficult to review such patch without access to a 
platform exhibiting such behavior ... IIRC IBM offers free access to 
open-source devs, I wonder if that would be a way.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Improve test coverage of geometric types

  2. Fix problems in handling the line data type

  3. Use the built-in float datatypes to implement geometric types

  4. Remove remaining GEODEBUG references from geo_ops.c

  5. Provide separate header file for built-in float types

  6. Refactor geometric functions and operators

  7. Fix crash in close_ps() for NaN input coordinates.

  8. Fix GiST index build for NaN values in geometric types.

  9. Enable building with Visual Studion 2013.

  10. Suppress -0 in the C field of lines computed by line_construct_pts().