Re: meson's in-tree libpq header search order vs -Dextra_include_dirs

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>

To: Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-10-31T18:14:38Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

ci: Add missing "set -e" to scripts run by su.
- c3359d1cf5e5 15.15 landed
- 4da1f66fae83 16.11 landed
- 61cd67425f1a 17.7 landed
- ae2381025a4c 18.1 landed
- cf638b46aff2 19 (unreleased) landed
Don't put library-supplied -L/-I switches before user-supplied ones.
- 4300d8b6a79d 19 (unreleased) cited

On 14/09/2025 06:23, Thomas Munro wrote:
> Added to commitfest: https://commitfest.postgresql.org/patch/6056/
> 
> I'm having to carry this patch in all my development branches for now
> or I can't build on one of my regular dev machines, so I'm quite keen
> to get this into the tree soon and would back-patch to 16.
> 
> I gather no one else is affected yet, but I assume you can see the
> problem on a Mac by installing PostgreSQL with Homebrew/MacPorts, or
> on CI if you do this to .cirrus.tasks.yml:
> 
>     setup_additional_packages_script: |
> -    #pkg install -y ...
> +    pkg install -y postgresql17-client

The patch seems harmless enough to me, no objections to committing it. 
However, I'm worried that we'll soon break it again. The new rule is 
apparently "include libpq first", but we have no way of enforcing it.

- Heikki