Re: Allow pg_archivecleanup to remove backup history files

torikoshia <torikoshia@oss.nttdata.com>

From: torikoshia <torikoshia@oss.nttdata.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, masao.fujii@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@postgresql.org

Date: 2023-06-20T13:27:36Z

Lists: pgsql-hackers

Attachments

v9-0001-Introduce-pg_archivecleanup-into-getopt_long.patch (text/x-diff) patch v9-0001
v9-0002-Refactored-to-reduce-the-nesting-level.patch (text/x-diff) patch v9-0002
v9-0003-Allow-pg_archivecleanup-to-remove-backup-history-.patch (text/x-diff) patch v9-0003

On 2023-06-19 14:37, Michael Paquier wrote:
> On Mon, Jun 19, 2023 at 11:24:29AM +0900, torikoshia wrote:
>> Thanks, now I understand what you meant.
> 
> If I may ask, why is the refactoring of 0003 done after the feature in
> 0002?  Shouldn't the order be reversed?  That would make for a cleaner
> git history.
> --
> Michael

Agreed.
Reversed the order of patches 0002 and 0003.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Commits

pg_archivecleanup: Add --clean-backup-history
- 3f8c98d0b631 17.0 landed
pg_archivecleanup: Refactor loop doing old segment removals
- 4a7556f77c44 17.0 landed
Introduce long options in pg_archivecleanup
- dd7c60f1935a 17.0 landed