Re: pg_rewind copies

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Cary Huang <cary.huang@highgo.ca>, pgsql-hackers@lists.postgresql.org
Date: 2021-01-22T13:26:12Z
Lists: pgsql-hackers

Attachments

On 16/12/2020 00:08, Cary Huang wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            not tested
> 
> Hello
> 
> The patch seems to do as described and the regression and tap tests are passing
> +	/*
> +	 * A local source is not expected to change while we're rewinding, so check
> +	 * that we size of the file matches our earlier expectation.
> +	 */
> Is this a tyoo?

Yep, thanks! Attached is a new patch version, with that fixed and 
rebased. No other changes.

- Heikki

Commits

  1. pg_rewind: Fetch small files according to new size.