Re: General purpose hashing func in pgbench
Ildar Musin <i.musin@postgrespro.ru>
From: Ildar Musin <i.musin@postgrespro.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-29T09:43:05Z
Lists: pgsql-hackers
Attachments
- pgbench_hash_v11.patch (text/x-patch) patch v11
Hi Fabien, On 28.01.2018 11:10, Fabien COELHO wrote: > > Hello Ildar, > >> I did everything you mention here and attached a new version on the >> patch. > > Patch applies, compiles, runs ok. > > Alas, I still have a few more very minor comments about the doc, sorry > again: No problem : ) > > + <entry> <literal>default_seed</literal> </entry> > + <entry>random seed used in hash functions by default</entry> > > s/random //: the seed may or may not be random. > > The "In some cases several distinct distributions..." paragraph is also > just one line in the xml source file. It should be justified at about 80 > columns like others. > Fixed the doc, attached the patch. Thanks! -- Ildar Musin i.musin@postgrespro.ru
Commits
-
Add general purpose hasing functions to pgbench.
- e51a04840a1c 11.0 landed