Horton
Menu

Re: Typos in the code and README

Alexander Lakhin <exclusion@gmail.com>

View thread
From: Alexander Lakhin <exclusion@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2026-01-01T08:00:00Z
Lists: pgsql-hackers

Attachments

Hello hackers,

Please look at another collection of typos, inconsistencies, and lost
entities (most of them introduced in 2025, but not all). In passing, I'm
proposing to synchronize parameter names in function declarations with
implementations.

Typos:
all-forzen -> all-frozen
Historcally -> Historically
insallation -> installation
maintanence_work_mem -> maintenance_work_mem
ndicates -> indicates
noacess -> noaccess
parititoned -> partititoned

Inconsistent spelling:
brin_wi_index -> brin_wi_idx
bufhdr -> bufHdr
FullTransactionID -> FullTransactionId
GroupExprInfos - > GroupingExprInfos
HEAP_PRUNE_FREEZE -> HEAP_PAGE_PRUNE_FREEZE (per 1937ed706)
inferPredExprs -> inferIndexExprs
newRightLink -> newRightlink
paramtypmode -> paramtypmod
pg_stat_replication_slot -> pg_stat_replication_slots
READ_WRITE_PARSE_PLAN_TREES -> WRITE_READ_PARSE_PLAN_TREES
DEFAULT_DEBUG_READ_WRITE_PARSE_PLAN_TREES -> DEFAULT_DEBUG_WRITE_READ_PARSE_PLAN_TREES
ReloptInfo -> RelOptInfo
retain_conflict_info -> retain_dead_tuples (see a850be2fe)
TIDStore -> TidStore

Inconsistent parameter naming:
RangeVarCallbackForStats(..., Oid oldRelid, ...) -> RangeVarCallbackForStats(..., Oid oldRelId, ...)
heap_lock_updated_tuple(..., TransactionId prior_rawxmax, ...) -> heap_lock_updated_tuple(..., TransactionId 
prior_raw_xmax, ...)
StartupLogicalDecodingStatus(bool status_in_control_file) -> StartupLogicalDecodingStatus(bool last_status)
FetchRelationStates(..., bool *has_pending_sequences, ...) -> FetchRelationStates(..., bool *has_pending_subsequences, ...)
PredicateLockTwoPhaseFinish(FullTransactionId xid, -> PredicateLockTwoPhaseFinish(FullTransactionId fxid,
PredicateLockTwoPhaseFinish(TransactionId xid, -> PredicateLockTwoPhaseFinish(FullTransactionId fxid,
SetSequence(Oid relid, int64 next, bool is_called) -> SetSequence(Oid relid, int64 next, bool iscalled)
fdatasync(int fildes) -> fdatasync(int fd)
gai_strerror(int ecode) -> gai_strerror(int errcode)
llvm_copy_attributes(LLVMValueRef from, LLVMValueRef to) -> llvm_copy_attributes(LLVMValueRef v_from, LLVMValueRef v_to)
ox1(PlannerInfo *root, Gene *mom, Gene *dad, ...) -> ox1(PlannerInfo *root, Gene *tour1, Gene *tour2, ...)
ox2(PlannerInfo *root, Gene *mom, Gene *dad, ...) -> ox2(PlannerInfo *root, Gene *tour1, Gene *tour2, ...)
pg_pread(..., size_t nbyte, ...) -> pg_pread(..., size_t size, ...)
pg_pwrite(..., size_t nbyte, ...) -> pg_pwrite(..., size_t size, ...)
pgwin32_connect(..., int namelen) -> pgwin32_connect(..., int addrlen)
replace_s(..., int * adjustment) -> replace_s(..., int * adjptr)

There is also
extern int        pgwin32_recv(SOCKET s, char *buf, int len, int flags);
vs
pgwin32_recv(SOCKET s, char *buf, int len, int f)
but I've left at as-is; probably the change should be made in the
implementation...

Orphan entities:
CheckXLogLogicalInfo -> remove (came with 67c20979c [1])
HAVE_ATOMIC_H, HAVE_MBARRIER_H -> remove (per 25f36066d)
#ifdef BS_DEBUG in contrib/ltree/ltxtquery_io.c -> remove (introduced with 1dedbf2da)

The patch is attached for your convenience.

[1] The implementation was removed in v34-0001-Toggle-*.patch:
https://www.postgresql.org/message-id/flat/CAD21AoCVLeLYq09pQPaWs%2BJwdni5FuJ8v2jgq-u9_uFbcp6UbA%40mail.gmail.com

Best regards,
Alexander

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional