Horton

Re: Stronger safeguard for archive recovery not to miss data

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: David Steele <david@pgmasters.net>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Laurenz Albe <laurenz.albe@cybertec.at>, 'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>
Date: 2021-03-26T01:23:38Z
Lists: pgsql-hackers 

On 2021/03/25 23:21, David Steele wrote:
> On 1/25/21 3:55 AM, Laurenz Albe wrote:
>> On Mon, 2021-01-25 at 08:19 +0000, osumi.takamichi@fujitsu.com wrote:
>>>> I think you should pst another patch where the second, now superfluous, error
>>>> message is removed.
>>>
>>> Updated. This patch showed no failure during regression tests
>>> and has been aligned by pgindent.
>>
>> Looks good to me.
>> I'll set it to "ready for committer" again.
> 
> Fujii, does the new patch in [1] address your concerns?

No. I'm still not sure if this patch is good idea... I understand
why this safeguard is necessary. OTOH I'm afraid it increases
a bit the risk that users get unstartable database, i.e., lose whole database.
But maybe I'm concerned about rare case and my opinion is minority one.
So I'd like to hear more opinions about this patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Fix test added by commit 9de9294b0c.

  2. Stop archive recovery if WAL generated with wal_level=minimal is found.