Re: Performance regression with PostgreSQL 11 and partitioning

On 2018/06/26 23:43, Alvaro Herrera wrote:
> On 2018-Jun-25, Tom Lane wrote:
> 
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> On 2018-Jun-18, David Rowley wrote:
>>>> I've attached a patch which cleans up my earlier version and moves the
>>>> setup of the append_rel_array into its own function instead of
>>>> sneaking code into setup_simple_rel_arrays(). I've also now updated
>>>> the comment above find_childrel_appendrelinfo(), which is now an
>>>> unused function.
>>
>>> I checked that this patch fixes the originally reported performance
>>> regression.
>>> Unless there are objections, I intend to push this patch tomorrow.
>>
>> If find_childrel_appendrelinfo is now unused, we should remove it.
> 
> Agreed -- thanks for following up.  Pushed that way.

I noticed that there is a typo in a comment, fixed as follows in the
attached patch.

     /*
-     * append_rel_list is the same length as the above arrays, and holds
+     * append_rel_array is the same length as the above arrays, and holds
      * pointers to the corresponding AppendRelInfo entry indexed by
      * child_relid, or NULL if none.  The array itself is not allocated if
      * append_rel_list is empty.

Thanks,
Amit