Horton

Thread

Commits

  1. doc: Fix datatype for postgres_fdw option

  1. Fix analyze_sampling docs in postgres-fdw.sgml

    Shinya Kato <shinya11.kato@oss.nttdata.com> — 2024-03-04T05:27:41Z

    Hi!

I fixed analyze_sampling docs in postgres-fdw.sgml.
- Changed analyze_sampling type 'text' to 'string'
- Add a statement 'The option specified on a table overrides an option 
specified for the server.'

Do you think?

Regards,
Shinya Kato
NTT DATA GROUP CORPORATION

  2. Re: Fix analyze_sampling docs in postgres-fdw.sgml

    Laurenz Albe <laurenz.albe@cybertec.at> — 2024-03-04T08:37:30Z

    On Mon, 2024-03-04 at 14:27 +0900, Shinya Kato wrote:
> I fixed analyze_sampling docs in postgres-fdw.sgml.
> - Changed analyze_sampling type 'text' to 'string'

+1

> - Add a statement 'The option specified on a table overrides an option 
> specified for the server.'

I think that applies to all options.  It would be better to have a general
statement to that effect at the beginning of the "Options" section.

Yours,
Laurenz Albe

  3. Re: Fix analyze_sampling docs in postgres-fdw.sgml

    Daniel Gustafsson <daniel@yesql.se> — 2024-03-04T09:24:33Z

    > On 4 Mar 2024, at 09:37, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 
> On Mon, 2024-03-04 at 14:27 +0900, Shinya Kato wrote:
>> I fixed analyze_sampling docs in postgres-fdw.sgml.
>> - Changed analyze_sampling type 'text' to 'string'
> 
> +1

Agreed, that should be changed, will fix.

>> - Add a statement 'The option specified on a table overrides an option 
>> specified for the server.'
> 
> I think that applies to all options.  It would be better to have a general
> statement to that effect at the beginning of the "Options" section.

Yeah, that might be a good idead.

--
Daniel Gustafsson