Horton

Thread

Commits

  1. Fix incorrect return type

  1. fasthash32() returning uint64?

    Jeff Davis <pgsql@j-davis.com> — 2024-04-05T20:47:29Z

    In hashfn_unstable.h, fasthash32() is declared as:

  /* like fasthash64, but returns a 32-bit hashcode */
  static inline uint64
  fasthash32(const char *k, size_t len, uint64 seed)

Is the return type of uint64 a typo?

Regards,
	Jeff Davis

  2. Re: fasthash32() returning uint64?

    John Naylor <johncnaylorls@gmail.com> — 2024-04-06T01:08:19Z

    On Sat, Apr 6, 2024 at 3:47 AM Jeff Davis <pgsql@j-davis.com> wrote:
> In hashfn_unstable.h, fasthash32() is declared as:
>
>   /* like fasthash64, but returns a 32-bit hashcode */
>   static inline uint64
>   fasthash32(const char *k, size_t len, uint64 seed)
>
> Is the return type of uint64 a typo?

Yes it is, will fix, thanks!