Horton

Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: Joe Conway <mail@joeconway.com>, Chao Li <li.evan.chao@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>
Date: 2026-03-03T01:22:21Z
Lists: pgsql-hackers 
On 2/27/26 3:58 PM, Joe Conway wrote:
> On 2/27/26 01:04, Chao Li wrote:
>> What I'm interested in is the broader policy: when reviewing
>> patches, if we encounter a foo() declaration, should we consistently
>> request a change to foo(void)? If yes, the standard should be
>> documented somewhere.
> 
> Perhaps here?
> 
> https://wiki.postgresql.org/wiki/Committing_checklist

Nah, I think we should just enable the warnings unless we have a good 
reason not to.

Andreas

Commits

  1. Enable -Wstrict-prototypes and -Wold-style-definition by default

  2. Prevent -Wstrict-prototypes and -Wold-style-definition warnings

  3. style: define parameterless functions as foo(void).