Horton

Re: Some code cleanup for pgbench and pg_verifybackup

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-28T06:49:12Z
Lists: pgsql-hackers 
> [...] Thoughts?

For pgbench it is definitely ok to add the exit. For others the added 
exits look reasonable, but I do not know them intimately enough to be sure 
that it is the right thing to do in all cases.

> All that does not seem to enter into the category of things worth 
> back-patching, except for pg_verifybackup.

Yes.

-- 
Fabien.

Commits

  1. Add some missing exit() calls in error paths for various binaries

  2. Add missing exit() in pg_verifybackup when failing to find pg_waldump