Horton

Re: pgbench logging broken by time logic changes

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Gregory Smith <gregsmithpgsql@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, david.christensen@crunchydata.com
Date: 2021-07-09T05:14:32Z
Lists: pgsql-hackers 
Hello Thomas,

>>> Isn't it better if we only have to throw away the first one?).
>>
>> This should be the user decision to drop it or not, not the tool 
>> producing it, IMO.
>
> Let me try this complaint again. [...]

I understand your point.

For me removing silently the last bucket is not right because the sum of 
aggregates does not match the final grand total. This change is 
intentional and borders on a bug fix, which is what this patch was doing, 
even if it is also a small behavioral change: We should want the detailed 
and final reports in agreement.

I do agree that users should probably ignore the first and last lines.

> See attached.

Works for me: patch applies, global and local check ok. I'm fine with it.

If it was me, I'd still show the last bucket, but it does not matter much.

-- 
Fabien.

Commits

  1. Fix pgbench timestamp bugs.

  2. Fix pattern matching logic for logs in TAP tests of pgbench

  3. pgbench: Improve time logic.

  4. pgbench: Synchronize client threads.

  5. pgbench: refactor handling of stats tracking