Horton

Re: pgbench logging broken by time logic changes

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>, Thomas Munro <thomas.munro@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Gregory Smith <gregsmithpgsql@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, david.christensen@crunchydata.com
Date: 2021-06-22T10:06:45Z
Lists: pgsql-hackers

Attachments

Bonjour Michaël,

>> If this were core server code threatening data integrity I would be
>> inclined to be more strict, but after all pg_bench is a utility program,
>> and I think we can allow a little more latitude.
>
> +1.  Let's be flexible here.  It looks better to not rush a fix, and
> we still have some time ahead.

Attached an updated v8 patch which adds (reinstate) an improved TAP test 
which would have caught the various regressions on logs.

Given that such tests were removed once before, I'm unsure whether they 
will be acceptable, despite that their usefulness has been clearly 
demonstrated. At least it is for the record. Sigh:-(

-- 
Fabien.

Commits

  1. Fix pgbench timestamp bugs.

  2. Fix pattern matching logic for logs in TAP tests of pgbench

  3. pgbench: Improve time logic.

  4. pgbench: Synchronize client threads.

  5. pgbench: refactor handling of stats tracking