Re: pgbench logging broken by time logic changes

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Gregory Smith <gregsmithpgsql@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, david.christensen@crunchydata.com

Date: 2021-06-17T20:53:26Z

Lists: pgsql-hackers

Hello Thomas,

> I prepared a draft revert patch for discussion, just in case it comes
> in handy.  This reverts "pgbench: Improve time logic.", but "pgbench:
> Synchronize client threads." remains (slightly rearranged).

I had a quick look.

I had forgotten that this patch also fixed the long-running brain-damaged 
tps computation that has been bothering me for years, so that one sane 
performance figure is now reported instead of two not-clear-to-interpret 
take-your-pick figures.

It would be a real loss if this user-facing fix is removed in the 
process:-(

-- 
Fabien.

Commits

Fix pgbench timestamp bugs.
- 5614a0f78eaa 14.0 landed
- 0e39a608ed55 15.0 landed
Fix pattern matching logic for logs in TAP tests of pgbench
- 0efd2a1a66dd 11.13 landed
- 79ff96aa9d9a 12.8 landed
- 7a9eaf111ac0 13.4 landed
- c13585fe9e55 14.0 landed
pgbench: Improve time logic.
- 547f04e7348b 14.0 cited
pgbench: Synchronize client threads.
- aeb57af8e640 14.0 cited
pgbench: refactor handling of stats tracking
- b60376649600 9.6.0 cited