Horton

Re: pgbench - refactor init functions with buffers

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: David Steele <david@pgmasters.net>
Cc: Andres Freund <andres@anarazel.de>, Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-03-27T22:59:24Z
Lists: pgsql-hackers 
>> Ok. I find it strange to mix PQExpBuffer & StringInfo in the same file.
>
> Agreed, but we'd rather use StringInfo going forward.  However, I don't think 
> that puts you on the hook for updating all the PQExpBuffer references.
>
> Unless you want to...

I cannot say that I "want" to fix something which already works the same 
way, because it is against my coding principles.

However there may be some fun in writing a little script to replace one 
with the other automatically. I counted nearly 3500 calls under src/bin.

-- 
Fabien.

Commits

  1. pgbench: Use PQExpBuffer to simplify code that constructs SQL.

  2. Make command order in test more sensible