Re: pgbench - add pseudo-random permutation function

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Hironobu SUZUKI <hironobu@interdb.jp>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, David Steele <david@pgmasters.net>
Date: 2020-01-05T09:02:29Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. pgbench: Function to generate random permutations.

  2. Add basic support for using the POPCNT and SSE4.2s LZCNT opcodes

  3. Further improve code for probing the availability of ARM CRC instructions.

> This patch was marked as RFC on 2019-03-30, but since then there have 
> been a couple more issues pointed out in a review by Thomas Munro, and 
> it went through 2019-09 and 2019-11 without any attention. Is the RFC 
> status still appropriate?

Thomas review was about comments/documentation wording and asking for 
explanations, which I think I addressed, and the code did not actually 
change, so I'm not sure that the "needs review" is really needed, but do 
as you feel.


-- 
Fabien