Horton

Re: pgbench - allow to create partitioned tables

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Asif Rehman <asifr.rehman@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-03T12:07:33Z
Lists: pgsql-hackers

Attachments

Hello Peter,

>>> The documentation and pgbench --help output that accompanied this patch
>>> claims that the argument to pgbench --partition-method is optional and
>>> defaults to "range", but that is not actually the case, as the
>>> implementation requires an argument.  Could you please sort this out?
>> 
>> AFAICS, if the user omits this argument, then the default is range as
>> specified in docs.  I tried by using something like 'pgbench.exe -i -s
>> 1 --partitions=2 postgres' and then run 'pgbench -S postgres'.
>
> Ah, the way I interpreted this is that the argument to --partition-method 
> itself is optional.

Yep. Optionnal stuff would be in [], where () is used for choices.

Would the attached have improved your understanding? It is somehow more 
consistent with other help lines.

-- 
Fabien.

Commits

  1. pgbench: add --partitions and --partition-method options.