Horton

Re: pgbench - use pg logging capabilities

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-01T21:55:29Z
Lists: pgsql-hackers

Attachments

Hello Peter,

> The patch seems pretty straightforward, but this
>
> +/*
> + * Convenient shorcuts
> + */
> +#define fatal pg_log_fatal
> +#define error pg_log_error
> +#define warning pg_log_warning
> +#define info pg_log_info
> +#define debug pg_log_debug
>
> seems counterproductive.  Let's just use the normal function names.

I'm trying to keep the column width under control, but if you like it 
wider, here it is.

Compared to v1 I have also made a few changes to be more consistent when 
using fatal/error/info.

-- 
Fabien.

Commits

  1. pgbench: Make more debug messages use common logging API

  2. pgbench: Use common logging API