Horton

Re: pgbench - extend initialization phase control

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: btkimurayuzk <btkimurayuzk@oss.nttdata.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, btendouan <btendouan@oss.nttdata.com>, "ibrar.ahmad@gmail.com:" <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-07T08:18:06Z
Lists: pgsql-hackers 
>>> I think that it may break --no-vacuum, and I thought that there may be
>>> other option which remove things, eventually. Also, having a NO-OP looks
>>> ok to me.
>> 
>> As far as I read the code, checkInitSteps() checks the initialization
>> steps that users specified. The initialization steps string that
>> "v" was replaced with blank character is not given to checkInitSteps().
>> So ISTM that dropping the handling of blank character from
>> checkInitSteps() doesn't break --no-vacuum.
>> 
> This is a patch which does not allow space character in -I options .

I do not think that this is desirable. It would be a regression, and 
allowing a no-op is not an issue in anyway.

-- 
Fabien Coelho - CRI, MINES ParisTech

Commits

  1. Add query cancellation capabilities in pgbench init phase

  2. Add "G" (server-side data generation) as an initialization step in pgbench.