Re: pgbench - allow to create partitioned tables

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Asif Rehman <asifr.rehman@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-10-01T14:48:33Z
Lists: pgsql-hackers
>> Yeah, I know that, but this doesn't look quite right.  I mean to say
>> whatever we want to say via this message is correct, but I am not
>> completely happy with the display part.  How about something like:
>> "pgbench_accounts is missing, you need to do initialization (\"pgbench
>> -i\") in database \"%s\"\n"?  Feel free to propose something else on
>> similar lines?  If possible, I want to convey this information in a single
>> sentence.
>>
>> How about, "pgbench_accounts is missing, initialize (\"pgbench -i\") in
> database \"%s\"\n"?

I think that we should not presume too much about the solution: perhaps 
the user did not specify the right database or host and it has nothing to 
do with initialization.

Maybe something like:

"pgbench_accounts is missing, perhaps you need to initialize (\"pgbench 
-i\") in database \"%s\"\n"

The two sentences approach has the logic of "error" and a separate "hint" 
which is often used.

-- 
Fabien.



Commits

  1. pgbench: add --partitions and --partition-method options.