Re: pgbench - allow to create partitioned tables
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
Asif Rehman <asifr.rehman@gmail.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-10-01T06:20:59Z
Lists: pgsql-hackers
Hello Amit, > 1. ran pgindent > 2. As per Alvaro's suggestions move few function definitions. > 3. Changed one or two comments and fixed spelling at one place. Thanks for the improvements. Not sure why you put "XXX - " in front of "append_fillfactor" comment, though. > + fprintf(stderr, > + "no pgbench_accounts table found in search_path\n" > + "Perhaps you need to do initialization (\"pgbench -i\") in database > \"%s\"\n", PQdb(con)); > Can anyone else think of a better error message either in wording or > style for above case? No better idea from me. The second part is a duplicate from a earlier comment, when getting the scale fails. -- Fabien.
Commits
-
pgbench: add --partitions and --partition-method options.
- b1c1aa531823 13.0 landed