Horton

Re: pgbench - allow to create partitioned tables

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Asif Rehman <asifr.rehman@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-09-18T07:31:40Z
Lists: pgsql-hackers

Attachments

Hello Amit,

> +                    fprintf(stderr, "invalid partition type,
> expecting \"range\" or \"hash\","
>
> How about "partitioning method" instead of "partition type"?

Indeed, this is a left over from a previous version.

> +            fprintf(stderr, "--partition-method requires actual
> partitioning with --partitions\n");
>
> [...] "--partition-method requires --partitions to be greater than zero"


I think the first suggestion is clear enough. I've put a shorter variant 
in the same spirit:

   "--partitions-method requires greater than zero --partitions"

Attached v10 fixes both messages.

-- 
Fabien.

Commits

  1. pgbench: add --partitions and --partition-method options.