Horton

Re: pg_upgrade: Error out on too many command-line arguments

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>, Michael Paquier <michael@paquier.xyz>, Julien Rouhaud <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-30T06:44:28Z
Lists: pgsql-hackers

Attachments

Hello Peter,

>>     On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote:
>>    > I did some searching, and oid2name.c is also missing this.
>>
>>     And pgbench, no?
>>  
>> Yes, the patch is slightly different.
>
> Thanks, pushed all that together.

Great!

Could we maintain coverage by adding a TAP test? See 1 liner attached.

-- 
Fabien.

Commits

  1. Error out on too many command-line arguments