Re: pgbench - add option to show actual builtin script code
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-07-11T16:20:14Z
Lists: pgsql-hackers
Hello Andrew, >>> Now the patch is good now. >>> >>> The new status of this patch is: Ready for Committer > > Why aren't we instead putting the exact scripts in the documentation? > Having to call pgbench with a special flag to get the script text seems > a bit odd. A typical use case I had is to create a new script by modifying an existing one for testing or debug. I prefer "command > file.sql ; vi file.sql" to hazardous copy-pasting stuff from html pages. I do not think that it is worth replicating all scripts inside the doc, they are not that interesting, especially if more are added. Currently, out of the 3 scripts, only one is in the doc, and nobody complained:-) Now, they could be added to the documentation, but I'd like the option anyway. -- Fabien.
Commits
-
Provide pgbench --show-script to dump built-in scripts.
- 5823677acc56 13.0 landed