Horton

Re: pgbench - add option to show actual builtin script code

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Fabien Coelho <postgresql.org@coelho.net>
Date: 2019-05-02T14:25:42Z
Lists: pgsql-hackers

Attachments

Hello,

> Patch looks good to me, and work fine on my machine. One minor 
> observation is option 'list' mostly used to list the elements like 
> "pgbench -b list" shows the available builtin scripts. Therefore we 
> should use a word which seems to be more relevant like --show-script.

Thanks for the review.

Here is a version with "--show-script". I also thought about "--listing", 
maybe.

> The new status of this patch is: Waiting on Author

-- 
Fabien.

Commits

  1. Provide pgbench --show-script to dump built-in scripts.