Horton

Re: pgbench - add minimal stats on initialization

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-04-10T17:39:00Z
Lists: pgsql-hackers

Attachments

Hello,

Thanks for the feedback.

> I have one minor observation that in case of initDropTables you log
> 'drop' and in case of initCreateTables you log 'create table'. We need
> to be consistent. The "drop tables" and "create tables" are the best
> fit here.

Ok.

Attached version does that, plus avoids re-assigning "first" on each loop, 
plus checks that --no-vacuum indeed removes all vacuums in the TAP test.

-- 
Fabien.

Commits

  1. Report the time taken by pgbench initialization steps.