Horton

Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Michael Banck <michael.banck@credativ.de>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, alvherre@2ndquadrant.com, mailings@oopsware.de, thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2019-04-02T08:10:34Z
Lists: pgsql-hackers 
>> For pg_checksums, probably some improvement patch will be submitted later,
>> if someone feels like it.
>
> Let's see.  I think that what we have now in v12 is good enough for
> checksum operations on an offline cluster.  And my take is that we
> should focus more on online checksum verification for v13 and future
> versions.

I agree.

For online, we should want throttling so that the check can have a reduced 
performance impact when scrubbing.

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums