Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Michael Banck <michael.banck@credativ.de>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, alvherre@2ndquadrant.com, mailings@oopsware.de, thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2019-04-02T06:11:45Z
Lists: pgsql-hackers
Bonjour Michaël,

>> Maybe it should be -P X where X is the expected
>> delay in seconds. Pgbench progress reporting on initialization basically
>> outputs 10 rows per second, probably it is too much.
>
> I cannot say for pgbench.  I personally think that's a lot but you are
> the one who wrote it as such I guess.

Nope, this was way before I intervened. ISTM that a patch was submitted to 
get per second or slower progress reporting on the initalization, and it 
was rejected. Now that there are many SSD, maybe I could bring it back. An 
issue with pbbench is that the reported time and progress is for the 
insertion phase only, but PK and other FK declaration take as much time 
and are not included, so I'm not sure it can be much better.

For pg_checksums, probably some improvement patch will be submitted later, 
if someone feels like it.

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums