Horton

Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Banck <michael.banck@credativ.de>
Cc: Michael Paquier <michael@paquier.xyz>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, alvherre@2ndquadrant.com, mailings@oopsware.de, thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2019-03-28T09:08:36Z
Lists: pgsql-hackers 
>> Otherwise a very minor comment: I'd invert !force and the computations in
>> the return condition to avoid the computations when not needed.
>
> The force is only ever true right at the end of the program so it would
> not save anything really and detract from the main gist of that
> statement, so I left it as-is.

Ok.

I marked it as ready, but I'd advise that you split it in (1) progress and 
(2) signal toggling so that the first part is more likely to make it 
before 12 freeze.

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums