Horton

Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Banck <michael.banck@credativ.de>
Cc: Michael Paquier <michael@paquier.xyz>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, alvherre@2ndquadrant.com, mailings@oopsware.de, thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2019-03-28T14:53:59Z
Lists: pgsql-hackers 
Hallo Michael,

>> but I'd advise that you split it in (1) progress and (2) signal
>> toggling so that the first part is more likely to make it before 12
>> freeze.
>
> Ok, done so in the attached.

Fine.

I think that it is good to show the overall impact of the signal stuff, in 
particular the fact that the size must always be computed if the progress 
may be activated.

Also, I'd suggest to add "volatile" on the show_progress variable in the 
second patch.

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums