Horton

Re: Offline enabling/disabling of data checksums

Fabien COELHO <fabien.coelho@mines-paristech.fr>

View thread View on postgr.es
From: Fabien COELHO <fabien.coelho@mines-paristech.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Michael Banck <michael.banck@credativ.de>, Magnus Hagander <magnus@hagander.net>, Sergei Kornilov <sk@zsrv.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-26T12:41:38Z
Lists: pgsql-hackers 
Bonjour Michaël,

>> Here is an attempt at improving the Notes. [...]
>
> So, the ordering of the notes for each paragraph is as follows: 1) 
> Replication issues when mixing different checksum setups across nodes. 
> 2) Consistency of the operations if killed. 3) Don't start Postgres 
> while the operation runs.
>
> Your proposal is to switch the order of the paragraphs to 3), 1) and
> then 2).

Yes. I suggest to emphasize cluster corruption risks by putting them 
first.

> Do others have any opinion?  I am fine with the current
> order of things, still it may make sense to tweaks the docs.
>
> In the paragraph related to replication, the second statement is
> switched to be first so as the docs warn first, and then give
> recommendations.

Yep.

> This part makes sense.

Yep!

> I am not sure that "checksum status" is a correct term.  It seems to
> me that "same configuration for data checksums as before the tool ran"
> or something like that would be more correct.

Possibly, I cannot say.

-- 
Fabien.

Commits

  1. Reorganize Notes section in documentation of pg_checksums

  2. Add option -N/--no-sync to pg_checksums

  3. Add options to enable and disable checksums in pg_checksums

  4. Refactor more code logic to update the control file

  5. Rename pg_verify_checksums to pg_checksums

  6. Fix cross-version compatibility checks of pg_verify_checksums

  7. Add routine able to update the control file to src/common/