Re: Progress reporting for pg_verify_checksums

> I have rebased it now.

Thanks. Will look at it.

>> If the all of aboves are involved, the line would look as the
>> follows.
>>
>> [=======================             ] ( 63% of 12.53 GB, 179 MB/s, ETC 26s)
>>
>> # Note that this is just an opinion.
>>
>> (pg_checksum runs fast at the beginning so ETC behaves somewhat
>> strange in the meanwhile.)
>
> I haven't changed that for now as it seems to be a bit more involved.
> I'd like to hear other opinions on whether that is worthwhile?

I think that the bar is overkill, but ETC is easy and nice.

>>> +     /* we handle SIGUSR1 only, and toggle the value of show_progress */
>>> +     if (signum == SIGUSR1)
>>> +             show_progress = !show_progress;
>>
>> SIGUSR1 *toggles* progress.
>
> Not sure what you mean here,

Probably it is meant to simplify the comment?

-- 
Fabien.