Horton

Re: Offline enabling/disabling of data checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Michael Banck <michael.banck@credativ.de>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-18T06:07:27Z
Lists: pgsql-hackers 
Bonjour Michaël,

> Here are my notes about the fixes:

Thanks for the fixes.

> - pg_resetwal got broken because the path to the control file was
> incorrect.  Running tests of pg_upgrade or the TAP tests of
> pg_resetwal showed the failure.

Hmmm… I thought I had done that with "make check-world":-(

> - pg_rewind was issuing a flush of the control file even if --no-sync
> was used.

Indeed, I missed this one.

> - Nit: incorrect header order in controldata_utils.c.  I have kept the
> backend-only includes grouped though.

I'll pay attention to that the next time.

Thanks for the push.

-- 
Fabien.

Commits

  1. Reorganize Notes section in documentation of pg_checksums

  2. Add option -N/--no-sync to pg_checksums

  3. Add options to enable and disable checksums in pg_checksums

  4. Refactor more code logic to update the control file

  5. Rename pg_verify_checksums to pg_checksums

  6. Fix cross-version compatibility checks of pg_verify_checksums

  7. Add routine able to update the control file to src/common/